Re: Review Request: Fïx two little bugs: one with default contrast settings and one with plasma popup alignment.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103529/#review9279
-----------------------------------------------------------


half a ship it:
i think you should commit the part that fixes the off by one positioning.

the contrast value, i don't really get a reason (and should be done in another commit anyways)

- Marco Martin


On Dec. 24, 2011, 5:35 p.m., Nikita Churaev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103529/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2011, 5:35 p.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> -------
> 
> Contrast bug: KGlobalSettings::contrast() returns different default value than KGlobalSettings::contrastF(). Oxygen uses contrastF() while KDE color control module uses contrast(), so when the user first uses color settings, contrast appears to change.
> 
> Plasma popup bug: Right-aligned popups are one pixel away from right edge of the screen and top-aligned popups (when panel is on top) are one pixel inside panel. This is because the bug in QRect, where right() and bottom() value return value that is less than the true value by one. This is a feature-bug that Qt developers aren't going to fix because of compatiability reasons. My patch just applies + 1 compensation to all expressions that use QRect::right() and QRect::bottom().
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kglobalsettings.cpp 819b314 
>   plasma/corona.cpp 366a9df 
> 
> Diff: http://git.reviewboard.kde.org/r/103529/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nikita Churaev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111226/bf549ec6/attachment.html>