Review Request: Update 'Pattern Wallpaper' configuration interface layout

Marco Martin notmart at gmail.com
Tue Dec 20 12:12:59 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103365/#review9120
-----------------------------------------------------------

Ship it!


looks fine to me


wallpapers/pattern/pattern.h
<http://git.reviewboard.kde.org/r/103365/#comment7545>

    remove whitespace



wallpapers/pattern/pattern.cpp
<http://git.reviewboard.kde.org/r/103365/#comment7546>

    same


- Marco Martin


On Dec. 9, 2011, 2:42 p.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103365/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 2:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I have changed the layout of 'Pattern Wallpaper' add on to follow 'Image' or 'Virus' layout.
> 
> 
> Diffs
> -----
> 
>   wallpapers/pattern/CMakeLists.txt 1681916 
>   wallpapers/pattern/config.ui 12d1d24 
>   wallpapers/pattern/pattern.h 117835b 
>   wallpapers/pattern/pattern.cpp b4a16a0 
> 
> Diff: http://git.reviewboard.kde.org/r/103365/diff/diff
> 
> 
> Testing
> -------
> 
> Tested against master
> 
> 
> Screenshots
> -----------
> 
> pattern config interface
>   http://git.reviewboard.kde.org/r/103365/s/356/
> 
> 
> Thanks,
> 
> Reza Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111220/1deb06b3/attachment.html>


More information about the Plasma-devel mailing list