Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

Lamarque Vieira Souza lamarque at kde.org
Mon Dec 19 22:15:33 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103469/
-----------------------------------------------------------

(Updated Dec. 19, 2011, 10:15 p.m.)


Review request for kdelibs and Plasma.


Changes
-------

Add KLocale::reparseConfiguration() and make KLocalePrivate::initFormat() public.


Description
-------

This is patch number 3 to fix bug #289094 (top bar time incorrectly displays in 24 hour format). The other patches are against plasma-mobile and kde-workspace (http://git.reviewboard.kde.org/r/103434), all three patches must be applied to fix the bug. I think this is a much simpler solution than the one I suggested in http://git.reviewboard.kde.org/r/103434.


This addresses bug 289094.
    http://bugs.kde.org/show_bug.cgi?id=289094


Diffs (updated)
-----

  kdecore/localization/klocale.h 3495431 
  kdecore/localization/klocale.cpp 499bf11 
  kdecore/localization/klocale_p.h 4ed8e3f 
  kdeui/kernel/kglobalsettings.h cb8f7e2 
  kdeui/kernel/kglobalsettings.cpp 819b314 

Diff: http://git.reviewboard.kde.org/r/103469/diff/diff


Testing
-------


Thanks,

Lamarque Vieira Souza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111219/1e63287a/attachment.html>


More information about the Plasma-devel mailing list