Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

[Lamarque V. Souza]

Em Monday 19 December 2011, David Faure escreveu:
> On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote:
> > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote:
> > > > kdeui/kernel/kglobalsettings.cpp, line 886
> > > > <http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867
> > > > lin e886>> >
> > > > 
> > > >     I like the idea (KGlobalSettings reparsing configuration), but
> > > >     not the implementation (setLanguage(langage)). Can't KLocale get
> > > >     a reparseConfiguration() (to reuse the KConfig naming) ?
> > 
> > KLocale::reparseConfiguration() would be just a call to
> > KLocalePrivate::initFormat(), but initFormat is protected. I will have to
> > make it public to use it in KLocale::reparseConfiguration, wouldn't that
> > break binary compatibility?
> 
> Aeh? If it's called KLocalePrivate it's a private class, you can do
> whatever you want with it.

	Well, it's called KLocalePrivate but it has a lot of protected methods 
that KLocale cannot access, initFormat is one of them:

../../kdecore/localization/klocale_p.h: In member function 'void 
KLocale::reparseConfiguration()':
../../kdecore/localization/klocale_p.h:81:18: error: 'virtual void 
KLocalePrivate::initFormat()' is protected
../../kdecore/localization/klocale.cpp:786:19: error: within this context

-- 
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111219/abd520d4/attachment.html>