Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

[Giorgos Tsiapaliwkas]

> On Dec. 16, 2011, 3:25 p.m., Aaron J. Seigo wrote:
> > try using inkscape rather than carbon for the svg changes.

it worked!!(no issues)

Because i can't create a diff of the removed files here,


diff --git a/applets/rssnow/CMakeLists.txt b/applets/rssnow/CMakeLists.txt
index 5762dbf..72be160 100644
--- a/applets/rssnow/CMakeLists.txt
+++ b/applets/rssnow/CMakeLists.txt
@@ -15,8 +15,7 @@ install(TARGETS plasma_applet_rssnow DESTINATION ${PLUGIN_INSTALL_DIR})
 install(FILES plasma-applet-rssnow.desktop DESTINATION ${SERVICES_INSTALL_DIR})
 install(FILES feeds DESTINATION ${DATA_INSTALL_DIR}/rssnow)
 install(FILES
-left.svgz
-right.svgz
+arrows.svgz
 rssnow.svgz
 background.svgz
 DESTINATION ${DATA_INSTALL_DIR}/desktoptheme/default/rssnow/)
diff --git a/applets/rssnow/left.svgz b/applets/rssnow/left.svgz
deleted file mode 100644
index ca03cd3..0000000
Binary files a/applets/rssnow/left.svgz and /dev/null differ
diff --git a/applets/rssnow/right.svgz b/applets/rssnow/right.svgz
deleted file mode 100644
index c3c2285..0000000
Binary files a/applets/rssnow/right.svgz and /dev/null differ


$ git status                                                                                                                                                                                                                                 
# On branch master
# Changes not staged for commit:
#   (use "git add/rm <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       modified:   applets/rssnow/CMakeLists.txt
#       deleted:    applets/rssnow/left.svgz
#       deleted:    applets/rssnow/right.svgz


i know it is lame..

should i push?


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103347/#review9007
-----------------------------------------------------------


On Dec. 16, 2011, 12:12 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103347/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 12:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> the Timer component will reset to zero when the user clicks the arrows.
> Also i made some fixes in the coding style.
> 
> thanks in advance
> 
> 
> Diffs
> -----
> 
>   rssnow/package/contents/ui/ListItemEntry.qml dac3f93 
>   rssnow/package/contents/ui/main.qml e39a1f6 
> 
> Diff: http://git.reviewboard.kde.org/r/103347/diff/diff
> 
> 
> Testing
> -------
> 
> everything is ok
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111217/b4724d2e/attachment.html>