Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

[Sujith Haridasan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103393/
-----------------------------------------------------------

(Updated Dec. 16, 2011, 6:20 a.m.)


Review request for Plasma.


Changes
-------

Updated the patch with changes:
1) Solid::Networking::shouldConnect() to shouldConnect()
2) Moving the connect to before line 408 if condition.


Description
-------

Adding patch for the TODO, mentioned in the folderview.cpp file. This patch looks whether the url is local or remote. If its remote then checks for the network status of the host machine. If the host machine is not connected to the network then returns.


Diffs (updated)
-----

  plasma/applets/folderview/folderview.h 4896f07 
  plasma/applets/folderview/folderview.cpp 43d0511 

Diff: http://git.reviewboard.kde.org/r/103393/diff/diff


Testing
-------

Tested by removing the host from the network and by adding the host to the network.


Thanks,

Sujith Haridasan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111216/df36c4a3/attachment-0001.html>