Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

Sujith Haridasan sujith.h at
Wed Dec 14 03:21:29 UTC 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 14, 2011, 3:21 a.m.)

Review request for Plasma.


Updated the patch with:
1)Solid::Networking::shouldConnect() if host is connected to the network.
2)Replaced the KNotification with Plasma::Applet::showMessage.
3)Checked the indentation.


Adding patch for the TODO, mentioned in the folderview.cpp file. This patch looks whether the url is local or remote. If its remote then checks for the network status of the host machine. If the host machine is not connected to the network then returns.

Diffs (updated)

  plasma/applets/folderview/folderview.cpp 43d0511 



Tested by removing the host from the network and by adding the host to the network.


Sujith Haridasan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Plasma-devel mailing list