Review Request: plasmoid qalculate - menu button

[Greg T]

> On Dec. 6, 2011, 2:16 p.m., Aaron J. Seigo wrote:
> > applets/qalculate/qalculate_applet.cpp, lines 235-237
> > <http://git.reviewboard.kde.org/r/103052/diff/1/?file=40280#file40280line235>
> >
> >     if this is to make m_output appear before m_historyButton in the layout, use insertItem instead of addItem :)

yeah good catch :) I suppose that I should mark these things fixed or is that your job? Oh and thanks for reviewing


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103052/#review8754
-----------------------------------------------------------


On Dec. 8, 2011, 8:48 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103052/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2011, 8:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hey dudes,
> I implemented a little menu that displays the last 10 results. improvement ideas?
> 
> I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid
> 
> 
> Diffs
> -----
> 
>   applets/qalculate/qalculate_applet.h aee14c0 
>   applets/qalculate/qalculate_applet.cpp 4da9241 
>   applets/qalculate/qalculate_history.h 59185ee 
>   applets/qalculate/qalculate_history.cpp 35592a7 
> 
> Diff: http://git.reviewboard.kde.org/r/103052/diff/diff
> 
> 
> Testing
> -------
> 
> seems to work
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111208/fb100d8a/attachment-0001.html>