Review Request: Activity Dataengine: Delete the KActivities::Info when an activity is removed

Aaron J. Seigo aseigo at kde.org
Wed Dec 7 15:47:39 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103351/#review8779
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Dec. 7, 2011, 3:30 p.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103351/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2011, 3:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The KActivities::Info was new'd when an activity was added, but not deleted when it was removed. This patch fixes this.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/activities/activityengine.h d57430b 
>   plasma/generic/dataengines/activities/activityengine.cpp eadd952 
> 
> Diff: http://git.reviewboard.kde.org/r/103351/diff/diff
> 
> 
> Testing
> -------
> 
> Removing some activities with plasmaengineexplorer running org.kde.activities seemed to work fine.
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111207/2cae06de/attachment.html>


More information about the Plasma-devel mailing list