Review Request: port dictionary qml to Plasma Components
Aaron J. Seigo
aseigo at kde.org
Tue Dec 6 14:12:45 UTC 2011
> On Nov. 17, 2011, 11:34 a.m., Marco Martin wrote:
> > dictionary/package/contents/ui/main.qml, line 80
> > <http://git.reviewboard.kde.org/r/103143/diff/1/?file=41047#file41047line80>
> >
> > clearbuttonShown is available again in the textfield api, so it can stay
>
> Giorgos Tsiapaliwkas wrote:
> Sorry for the delay..
> I added the clearButtonShown: true
> but i received the error that the property doesn't exist.
probably due to marco having a newer build than you did at the time? please push this into git in a branch if it isn't already so we can have it for merging into 4.9.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103143/#review8259
-----------------------------------------------------------
On Nov. 15, 2011, 3:54 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103143/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2011, 3:54 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hello,
>
> i ported the plasmoid to the plasma components and also add an archors property in order to be rendered properly.
>
>
> Diffs
> -----
>
> dictionary/package/contents/ui/main.qml e9cb9fc
>
> Diff: http://git.reviewboard.kde.org/r/103143/diff/diff
>
>
> Testing
> -------
>
> the PlasmaWidget.WebView doesn't expand in all the entire layout of the plasmoid.
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111206/4d16503d/attachment.html>
More information about the Plasma-devel
mailing list