Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

Giorgos Tsiapaliwkas terietor at gmail.com
Tue Dec 6 12:27:18 UTC 2011



> On Nov. 28, 2011, 3:46 p.m., Aaron J. Seigo wrote:
> > now that's a nice simplification :)
> 
> Aaron J. Seigo wrote:
>     one other note: please be sure that all the rest of the plasmate code that assumes this directory structure (if any) is modified to work properly with this new approach.

done and pushed :)


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102732/#review8567
-----------------------------------------------------------


On Nov. 28, 2011, 2:52 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102732/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2011, 2:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> for the moment the .plasmateprojectrc file exists as a mark for the projects created by plasmate.
> We want the file to be created in the creation of the project not in the load of the project,the patch does that.
> 
> cheers
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp 6ea7f0c 
>   startpage.h f16af4b 
>   startpage.cpp 75052b1 
> 
> Diff: http://git.reviewboard.kde.org/r/102732/diff/diff
> 
> 
> Testing
> -------
> 
> workinig
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111206/609fdcab/attachment.html>


More information about the Plasma-devel mailing list