Review Request: some fixes for cppcheck warnings

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103324/#review8697
-----------------------------------------------------------

Ship it!


lots of very nice fixes .. a comment in timesource.cpp would be very helpful to avoid regression on that fix in future. and as with the previous review, please commit each set of changes in a separate commit for atomicity.


plasma/generic/dataengines/time/timesource.cpp
<http://git.reviewboard.kde.org/r/103324/#comment7324>

    if this resolves a crash, please put a comment in here explaining that the order of deletion matters so it doesn't get reintroduced at some point in the future.


- Aaron J. Seigo


On Dec. 4, 2011, 12:22 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103324/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2011, 12:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I will not comment about the trivial ones (including the change from postfix to prefix in non trivial data types).
> Removed one duplicated Mask (unless there is one mask missing instead of the duplicated).
> In solarsystem.h and timesource.cpp. I need this change for plasma being able to start (I use the clock applet), otherwise it crashes here. 
> In singleview.cpp avoid a possible null pointer dereference.
> In stripwidget.cpp. Was it supposed to be a "boolean or" or a "bit or"?
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/time/timesource.cpp 47025ad 
>   plasma/generic/dataengines/time/solarsystem.h 10d6b30 
>   plasma/generic/dataengines/tasks/tasksource.cpp 0788cc4 
>   plasma/generic/dataengines/calendar/calendarengine.cpp f8b3a90 
>   plasma/generic/dataengines/filebrowser/filebrowserengine.cpp 1acd11f 
>   plasma/desktop/applets/tasks/abstracttaskitem.cpp 6f75bc5 
>   plasma/desktop/shell/panelview.cpp 98b8878 
>   plasma/desktop/shell/plasmaapp.cpp 7902cb7 
>   plasma/generic/shells/plasma-windowed/singleview.cpp 10d2113 
>   plasma/generic/tools/engineexplorer/main.cpp 7aa4c4a 
>   plasma/generic/tools/plasmoidviewer/main.cpp 5cd69a0 
>   plasma/generic/tools/wallpaperviewer/main.cpp c288056 
>   plasma/netbook/containments/sal/stripwidget.cpp cded4bc 
>   plasma/netbook/shell/plasmaapp.cpp b9d97cc 
> 
> Diff: http://git.reviewboard.kde.org/r/103324/diff/diff
> 
> 
> Testing
> -------
> 
> the solarsystem change has been playing nice here one month without crashes.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111204/fe4a4c71/attachment.html>