Review Request: Plasmate: Add mimetype support into the "executable scripts"

[Aaron J. Seigo]

> On Aug. 31, 2011, 11:15 a.m., Antonis Tsiapaliokas wrote:
> > in the files toolbar, there is a row with name "Metadata", in which in the "Plugin Details" there is KComboBox with name "API". Unfortunately the KComboBox is stuck on "c++" all the time. Also there is no support for understanding in which language the plugin has been written. So here is my idea, first i should fix the bug about the Metadata and after that i will use that to make the current patch better.

that sounds perfect :)

the API entry should be pulled from the X-Plasma-API= entry of the .desktop file; as they are things like "declarative" and "javascript", some translation will be needed. also, C++ shouldn't be shown in the metadata editor at all as Plasmate doesn't (on purpose) support c++ :)


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102357/#review6188
-----------------------------------------------------------


On Aug. 17, 2011, 7:42 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102357/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2011, 7:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hello
> 
> If you open the "files" toolbar and you try to add something new with the "New.." in the executable scripts, then if you don't add the .{qml,js,rb,py}, then the file will be saved without the mimetype extension. This patch is fixing this issue.If you don't like something into the names which i gave, then let me know :)
> 
> 
> Diffs
> -----
> 
>   editors/editpage.cpp d4b0082 
>   packagemodel.h a14033c 
>   packagemodel.cpp 8c0907a 
> 
> Diff: http://git.reviewboard.kde.org/r/102357/diff
> 
> 
> Testing
> -------
> 
> plasmate compiles fine. New files can be added into the other menus, without any issue. 
> 
> 
> Thanks,
> 
> Antonis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110831/5a0a013d/attachment.html>