Review Request: Implement automatic scanning of source code for required data engines

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102350/#review5880
-----------------------------------------------------------


to me seems quite good. other opinions?

the only problem as usual is that kdelibs master is frozen, so this should go in the frameworks branch

- Marco


On Aug. 21, 2011, 1:47 a.m., Kevin Kofler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102350/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2011, 1:47 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> For packages in scripting languages and distributed through OCS, this is fully
> automatic and triggered from Package::installPackage. If an
> X-Plasma-RequiredDataEngines entry is present in the .desktop file (even if
> empty), the dependency extraction is not run and the explicitly provided
> information is trusted instead.
> 
> For native distribution packages, we ship a tool called
> plasma-dataengine-depextractor which can be run at any time during the build
> process and which adds the dependency information to the relevant .desktop file.
> 
> Authors of plasmoids are encouraged to run plasma-dataengine-depextractor and/or
> fill in X-Plasma-RequiredDataEngines manually. (Please note that the list is
> expected to be comma-separated.)
> 
> This is the final portion of my GSoC 2011 project.
> 
> 
> Diffs
> -----
> 
>   plasma/CMakeLists.txt f929967 
>   plasma/depextractor/depextractor.cpp PRE-CREATION 
>   plasma/package.cpp 4c00d36 
>   plasma/private/componentinstaller.cpp 870667f 
>   plasma/private/componentinstaller_p.h f85cbb6 
> 
> Diff: http://git.reviewboard.kde.org/r/102350/diff
> 
> 
> Testing
> -------
> 
> Compiles on Fedora 15.
> 
> Tested plasma-dataengine-depextractor on the weather plasmoid, it detected the dependency on the weather dataengine correctly and wrote a valid X-Plasma-RequiredDataEngines entry into the .desktop file.
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110821/bbb60fcf/attachment.html>