Review Request: Plasmate: Add mimetype support into the "executable scripts"

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102357/#review5784
-----------------------------------------------------------


thanks for the patch and noticing this issue.

what would probably make more sense is to keep track of what language the project is being implemented in and get the default suffix based on that when creating a new script. looking for what extensions are already in use seems a bit on the hackish side and will end up breaking as soon as there are multiple script types (e.g. mixed js with qml) in use.


editors/editpage.cpp
<http://git.reviewboard.kde.org/r/102357/#comment5116>

    more indentation oddness ... it should also probably check to see if the file doesn't already have an extension; it may be completely correct that the user enters in something like "foobar.js" in a QML project, for instance.



packagemodel.cpp
<http://git.reviewboard.kde.org/r/102357/#comment5115>

    indentation seems rather off in this block:)


- Aaron J.


On Aug. 17, 2011, 7:42 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102357/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2011, 7:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hello
> 
> If you open the "files" toolbar and you try to add something new with the "New.." in the executable scripts, then if you don't add the .{qml,js,rb,py}, then the file will be saved without the mimetype extension. This patch is fixing this issue.If you don't like something into the names which i gave, then let me know :)
> 
> 
> Diffs
> -----
> 
>   editors/editpage.cpp d4b0082 
>   packagemodel.h a14033c 
>   packagemodel.cpp 8c0907a 
> 
> Diff: http://git.reviewboard.kde.org/r/102357/diff
> 
> 
> Testing
> -------
> 
> plasmate compiles fine. New files can be added into the other menus, without any issue. 
> 
> 
> Thanks,
> 
> Antonis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110818/4c162642/attachment-0001.html>