Review Request: Improve formatting of the events display on the calendar (applet)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102293/#review5762
-----------------------------------------------------------


This review has been submitted with commit d84ab98607be9a5cafa362b1ff5377befa400874 by Lasse Liehu to branch master.

- Commit


On Aug. 17, 2011, 7:03 a.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102293/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2011, 7:03 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> QDate::toString()'s date formatting doesn't work nicely for all languages and calendar systems, so changed to use KCalendarSystem for it. Also decreases indentation so less space is wasted horizontally.
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/calendar.cpp e1c7bc6 
> 
> Diff: http://git.reviewboard.kde.org/r/102293/diff
> 
> 
> Testing
> -------
> 
> Compiles, formatting works. See screenshots
> 
> 
> Screenshots
> -----------
> 
> Coptic calendar
>   http://git.reviewboard.kde.org/r/102293/s/229/
> Correct Finnish formatting
>   http://git.reviewboard.kde.org/r/102293/s/230/
> English (US) formatting
>   http://git.reviewboard.kde.org/r/102293/s/231/
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110817/ff4312b7/attachment.html>