Review Request: Make the size of abstracticon uniform in plasma 'Add Widgets' dialog

[Shaun Reich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102305/#review5652
-----------------------------------------------------------



libs/plasmagenericshell/abstracticon.cpp
<http://git.reviewboard.kde.org/r/102305/#comment5064>

    Please stay away from #define's.



libs/plasmagenericshell/abstracticon.cpp
<http://git.reviewboard.kde.org/r/102305/#comment5063>

    whitespace, whitespace, whitespace...(I recommend setting your editor to remove them)


- Shaun


On Aug. 11, 2011, 1:28 p.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102305/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2011, 1:28 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> In current codes, the size of abstracticon will follow the size of widget name.
> My diff is to make the size of abstracticon uniform in plasma 'Add Widgets' dialog, 
> by making the widget name into 2 lines and elided the text.
> 
> 
> Diffs
> -----
> 
>   libs/plasmagenericshell/abstracticon.cpp 0fbdb9e 
> 
> Diff: http://git.reviewboard.kde.org/r/102305/diff
> 
> 
> Testing
> -------
> 
> Tested against master
> 
> 
> Thanks,
> 
> Reza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110811/0be58a12/attachment.html>