Review Request: Turn optional workspace build deps into hard ones

Martin Gräßlin kde at martin-graesslin.com
Tue Aug 9 10:37:01 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102260/
-----------------------------------------------------------

Review request for kwin, Plasma and Alexander Neundorf.


Summary
-------

As discussed on our mailinglists here are the changes to turn optional build dependencies into hard ones for the X11 (!) workspaces.

I implemented it by extending the section of Q_WS_X11 in the global CMakeLists. For OpenGL I used a hack to have OpenGL optional and OpenGL ES optional but at least one of those two required. If there is a better way to test that please let me know.

All those changes should only affect the X11 builds.

Further adjustments to our project level CMakeLists should be implemented by the teams. I'll take care of kwin.


Diffs
-----

  CMakeLists.txt 3bdde01 

Diff: http://git.reviewboard.kde.org/r/102260/diff


Testing
-------

Tried all possible combinations of turning off OpenGL and OpenGL ES and everytime I got the expected result.


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110809/794caf37/attachment.html>


More information about the Plasma-devel mailing list