Review Request: Add a system tray option to always show all items

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100743/
-----------------------------------------------------------

(Updated Aug. 5, 2011, 5:14 p.m.)


Review request for Plasma.


Changes
-------

Updated the patch to retain the individual items' states as those which can be set when the option is off.
So the task's internal state does not need to be changed via setHidden(), and there is also no change
needed to the logic in TaskArea::checkVisibility().


Summary
-------

If the user wishes to have all system tray items visible at all times, there is no single setting to allow this.  The only option is to go to System Tray Settings - Entries and set all of the "Visibility" combo boxes to "Always Visible", and repeat this whenever a new item appears.

All versions of a popular closed source operating system have this option for the system tray.

This change adds a check box "Always show all system tray items" below the list on the Entries page.  Checking this sets all items (current and any new ones that may appear in future) to be always visible and disables the "Visibility" column.  It is still possible to access the "Keyboard Shortcut" column.

The default is for this option not to be set, so the system tray operation is the same as before.


Diffs (updated)
-----

  plasma/generic/applets/systemtray/ui/applet.h d6cc509 
  plasma/generic/applets/systemtray/ui/applet.cpp f3c6d9a 
  plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff 
  plasma/generic/applets/systemtray/ui/taskarea.h 9a47d16 
  plasma/generic/applets/systemtray/ui/taskarea.cpp f47515f 

Diff: http://git.reviewboard.kde.org/r/100743/diff


Testing
-------

Built kde-workspace with these changes, checked operation of system tray and settings dialogue with this option checked and not checked.


Thanks,

Jonathan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110805/5353ffd7/attachment.html>