Review Request: Qalculate: fix restoring of settings
Jef Steelant
jef at steelant.be
Thu Aug 4 13:28:57 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102208/
-----------------------------------------------------------
(Updated Aug. 4, 2011, 1:28 p.m.)
Review request for Plasma.
Changes
-------
Implemented changes after review
Note that I don't have commit rights, so someone else should commit the patch
Summary
-------
If settings were changed in the qalculate plasmoid, these settings were not restored after the plasmoid was restarted (i.e. a reboot).
The settings are now read in the configChanged() method of the applet and restored correctly.
Extra cleanup: the signal of the m_baseDisplaySpin has also been changed to valueChanged(), since a QSpinBox does not have a toggled() signal.
Diffs (updated)
-----
applets/qalculate/qalculate_applet.cpp 872e55f091fb8ada98a5623bfd36c54d45b95336
applets/qalculate/qalculate_settings.cpp 0cb9e494d3e4d787ed025cb88adee3c2e77626e0
Diff: http://git.reviewboard.kde.org/r/102208/diff
Testing
-------
Changed settings and reloaded qalcultate - no issues
Thanks,
Jef
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110804/971127d2/attachment-0001.html>
More information about the Plasma-devel
mailing list