Review Request: Attempt to fix systemtray's configuration interface layout

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102210/#review5394
-----------------------------------------------------------

Ship it!


beautiful; please commit!


- Aaron J.


On Aug. 4, 2011, 1:10 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102210/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2011, 1:10 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Summary
> -------
> 
> Fixes the column sizes by setting the resizeMode of the QTreeView's header to ResizeToContents. The shortcut column is too small for to display a shortcut like (Ctrl+Alt+C) but I think that's a bug in the widget itself, not sure though.
> Currently the dialog is resized automatically to fit the content and it is not at the screen's center anymore but I don't know how to fix that.
> 
> The bug report has a screenshot of the previous state (http://bugsfiles.kde.org/attachment.cgi?id=47847). I append two which show the new state.
> 
> 
> This addresses bug 241277.
>     http://bugs.kde.org/show_bug.cgi?id=241277
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/systemtray/ui/applet.cpp 89bd18d 
> 
> Diff: http://git.reviewboard.kde.org/r/102210/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> The whole screen with applied patch
>   http://git.reviewboard.kde.org/r/102210/s/218/
> Only the dialog with applied patch
>   http://git.reviewboard.kde.org/r/102210/s/219/
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110804/ee2a1ccd/attachment.html>