Review Request: Fix panel controller width when running on multiple monitors (plasma startup, restart and running xrandr while plasma running)

[Rafael Fernández López]

> On April 30, 2011, 7:26 a.m., Aaron J. Seigo wrote:
> > nice fix :) thanks for the patch .. please commit and push at your convenience. (committing to the 4.6 branch and cherry-picking to master would be awesome; otherwise, i'll do so when i see the commit)

It's always a pleasure :)


- Rafael Fernández


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101254/#review2983
-----------------------------------------------------------


On April 30, 2011, 12:48 a.m., Rafael Fernández López wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101254/
> -----------------------------------------------------------
> 
> (Updated April 30, 2011, 12:48 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I have multiple monitors (xrandr --output LVDS1 --auto --output VGA1 --primary --auto --right-of LVDS1). Left one: 1440x900, Right one: 1920x1080. The plasma panel when I run such command takes as maximum size only a portion of my big screen. I usually dragged the panel to the top, and to the back again, having it resized to my screen width. This has been a very annoying behavior for me. Even restarting plasma the same behavior was being shown again.
> 
> This patch fixes this situation. Basically, on the showEvent method we only need to adapt the maximum size of the panel controller, for afterwards calling syncToLocation, which will trigger some calculations that will end up (with the maximum size properly set before) with the correct size for this panel.
> 
> Additionally, it has been needed to adapt the syncToLocation method because of this change. With the values that were being set before (QWIDGETSIZE_MAX) when there was the need to update struts (this is, switching from horizontal to vertical [or reverse] layout), the panel controller got huge (full screen, except panel itself).
> 
> You can check the screenshots attached for visual information of the problem.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/panelcontroller.h 9e8297b 
>   plasma/desktop/shell/panelcontroller.cpp 5e0dde1 
> 
> Diff: http://git.reviewboard.kde.org/r/101254/diff
> 
> 
> Testing
> -------
> 
> Restart plasma with single screen (OK)
> Restart plasma with multiple screens (OK)
> Run xrandr while on single screen with plasma running (OK)
> Move panel around, from one edge to another, forcing to update struts (OK)
> 
> 
> Screenshots
> -----------
> 
> Plasma panel (before patch)
>   http://git.reviewboard.kde.org/r/101254/s/144/
> Plasma panel (after patch)
>   http://git.reviewboard.kde.org/r/101254/s/145/
> 
> 
> Thanks,
> 
> Rafael Fernández
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110430/52b62abc/attachment.htm