Review Request: Check for new comic strips

Matthias Fuchs mat69 at gmx.net
Sat Apr 30 12:33:47 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101252/
-----------------------------------------------------------

(Updated April 30, 2011, 10:33 a.m.)


Review request for Plasma and Aaron J. Seigo.


Changes
-------

Adds action to jump to the next tab with a new comic strip.

NOTE: The shortcut is not working, what can I do to fix that?

Btw. I'll look into the highlight tab stuff now.


Summary
-------

Checks if there a new comic strips for the chosen comics. The user can define a time intervall in minutes for that.
If a new comic strip is found, then the tab is "highlighted" by prepending a "*" to the tab text.
First I planned to change the tab text color but this is not possible, unless the NativeTabBar code would change.
But I think the way it is now works reasonable well.


Diffs (updated)
-----

  applets/comic/CMakeLists.txt b85cb33 
  applets/comic/checknewstrips.h PRE-CREATION 
  applets/comic/checknewstrips.cpp PRE-CREATION 
  applets/comic/comic.h ca55959 
  applets/comic/comic.cpp 814cca8 
  applets/comic/comicSettings.ui f7fdeed 
  applets/comic/comicarchivejob.cpp 33d1da4 
  applets/comic/configwidget.h 767dc3d 
  applets/comic/configwidget.cpp 0dfd9ab 
  applets/comic/imagewidget.cpp 15e1ddb 
  dataengines/comic/comicprovider.cpp 73f1791 

Diff: http://git.reviewboard.kde.org/r/101252/diff


Testing
-------


Screenshots
-----------


  http://git.reviewboard.kde.org/r/101252/s/142/

  http://git.reviewboard.kde.org/r/101252/s/143/


Thanks,

Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110430/b20a4382/attachment-0001.htm 


More information about the Plasma-devel mailing list