Review Request: plasmate:"more projects" renamed to ..

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101243/#review2930
-----------------------------------------------------------

Ship it!


looks good; some small suggestions is all.


startpage.cpp
<http://git.reviewboard.kde.org/r/101243/#comment2510>

    these 2 lines, being the same, can be moved out of the if/else. just put the QListWidgetItem *more(0); declaration before them as well.



startpage.cpp
<http://git.reviewboard.kde.org/r/101243/#comment2509>

    spaces: } else {


- Aaron J.


On April 27, 2011, 7:13 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101243/
> -----------------------------------------------------------
> 
> (Updated April 27, 2011, 7:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> hello,
> 
> the patch renames the "more projects" to "manage projects" if the projects are 0>= and <=4 and renames it to "manage and more project" for >5.
> 
> We decided to make this patch after a discussion at the plasma-devel with aseigo.
> 
> p.s.:i have git access i just need my patch to be reviewed.
> 
> 
> Diffs
> -----
> 
>   startpage.cpp c29f85f 
> 
> Diff: http://git.reviewboard.kde.org/r/101243/diff
> 
> 
> Testing
> -------
> 
> compiled and worked,with no issues.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110427/feb9c84f/attachment.htm