Review Request: Simplify the comic config ui

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101242/#review2921
-----------------------------------------------------------


great steps towards improvements; one further set of improvements is to get rid of the checkbox+spinner combos. instead, try sth like:

Comics cache: [ No size limit ] <== where No Limit is a "special text value" for, e.g., 0 which does the same as not checking the checkbox; a suffix of, e.g. " strips per comic" would help further disambiguate ("2 strips per comic")

Automatic update: [ Never ] <== Never is the special text for 0 (and equal to unchecking the box), and other values would be "Every %1 days"; or perhaps even get rid of "no automatic update" and just have "Automatic update: [ Daily / Every %1 Days ]"

- Aaron J.


On April 27, 2011, 10:47 a.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101242/
> -----------------------------------------------------------
> 
> (Updated April 27, 2011, 10:47 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Summary
> -------
> 
> Removes a lot of options to simplify the comic config.
> Amongst them now only tabs are supported instead of also choosing comics via a combo box. Further if just one entry is selected tabs will be hidden automatically.
> Also option to hide tabs and to change them after a certain time is remvoed.
> Where feasible options are on one line now instead of two.
> 
> 
> Diffs
> -----
> 
>   applets/comic/advancedsettings.ui 0d4bde9 
>   applets/comic/comic.h 7134c72 
>   applets/comic/comic.cpp 88a2e31 
>   applets/comic/comicSettings.ui 497ffbb 
>   applets/comic/configwidget.h ffc7618 
>   applets/comic/configwidget.cpp d9078d8 
> 
> Diff: http://git.reviewboard.kde.org/r/101242/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> general settings
>   http://git.reviewboard.kde.org/r/101242/s/138/
> advanced settings
>   http://git.reviewboard.kde.org/r/101242/s/139/
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110427/cab8fe3f/attachment.htm