Review Request: Supports creation of Comic Book Archives

Matthias Fuchs mat69 at gmx.net
Tue Apr 26 11:47:48 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101235/
-----------------------------------------------------------

Review request for Plasma and Aaron J. Seigo.


Summary
-------

Adds possiblity to create a Comic Book Archive (.cbz) for a range: All, BeginTo, EndTo, Range

The job is displayed using the global job tracker, though atm. I have not implemented the total number of files that have to be downloaded, since that is more complicated. I might do that later.

There is one thing I don't understand. How do I set an error that the job tracker ui will also display it? The way I am setting the error apparntly did not result in the plasma job ui tracker to display it.


Diffs
-----

  applets/comic/CMakeLists.txt 8513d9c 
  applets/comic/comic.h 7134c72 
  applets/comic/comic.cpp 88a2e31 
  applets/comic/comicarchivedialog.h PRE-CREATION 
  applets/comic/comicarchivedialog.cpp PRE-CREATION 
  applets/comic/comicarchivedialog.ui PRE-CREATION 
  applets/comic/comicarchivejob.h PRE-CREATION 
  applets/comic/comicarchivejob.cpp PRE-CREATION 
  dataengines/comic/comicprovider.cpp 73f1791 

Diff: http://git.reviewboard.kde.org/r/101235/diff


Testing
-------


Thanks,

Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110426/e06c4389/attachment.htm 


More information about the Plasma-devel mailing list