Review Request: Add "Icons" item to desktop theme details GUI

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101175/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

The "System Settings - Workspace Appearance - Desktop Theme - Details" dialogue allows individual theme elements to be selected from any of the available desktop themes.  However, there is no GUI option to select a theme's icons - those stored in the theme's 'icons/' subdirectory and used in the system tray.  None of the standard KDE themes provide their own icons - they all use the default ones from Air - but some themes on kde-look do.

This 1-line patch adds an "Icons" item to this dialogue.  Selecting and copying the icons from a theme is all automatically handled in DesktopThemeDetails::save() with no additional code changes being necessary.


Diffs
-----

  kcontrol/desktoptheme/desktopthemedetails.cpp 4daced9 

Diff: http://git.reviewboard.kde.org/r/101175/diff


Testing
-------

Built kde-workspace with these changes, checked operation of dialogue and that theme icons are correctly copied to user's $KDEDIR/share/apps/desktoptheme/.customized/icons.


Thanks,

Jonathan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110422/44e6b3b5/attachment.htm