Review Request: Fix bug197654: do not save config again when Apply button disabled

Aaron J. Seigo aseigo at kde.org
Thu Apr 21 14:16:04 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101159/#review2802
-----------------------------------------------------------

Ship it!


please commit & push :)

- Aaron J.


On April 21, 2011, 8:40 a.m., Max Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101159/
> -----------------------------------------------------------
> 
> (Updated April 21, 2011, 8:40 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Ignore save config again after click Ok button when Apply button disabled. On Desktop Settings dialog with Slideshow mode, the image would not change again when we click Ok button after we clicked Apply button. 
> 
> 
> This addresses bug 197654.
>     http://bugs.kde.org/show_bug.cgi?id=197654
> 
> 
> Diffs
> -----
> 
>   libs/plasmagenericshell/backgrounddialog.cpp 53ac05a 
> 
> Diff: http://git.reviewboard.kde.org/r/101159/diff
> 
> 
> Testing
> -------
> 
> It's works fine on my machine.
> 
> 
> Thanks,
> 
> Max
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110421/35ad8cc8/attachment.htm 


More information about the Plasma-devel mailing list