Review Request: Fix resizing of popup applets on panel resizing

Marco Martin notmart at gmail.com
Sun Apr 17 23:03:19 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101148/#review2708
-----------------------------------------------------------

Ship it!


good catch

- Marco


On April 17, 2011, 8:49 p.m., David Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101148/
> -----------------------------------------------------------
> 
> (Updated April 17, 2011, 8:49 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> Since commit 1ed8e4ca6b53c2338d8da8e616752f0426038961 popup applets as Shelf and Places (kde-look.org) do not resize when the panel resizes.
> This patch ensures the icon is added to the widget layout before the function returns.
> 
> 
> This addresses bug 268104.
>     http://bugs.kde.org/show_bug.cgi?id=268104
> 
> 
> Diffs
> -----
> 
>   plasma/popupapplet.cpp 9238bd1 
> 
> Diff: http://git.reviewboard.kde.org/r/101148/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110417/27a4116f/attachment.htm 


More information about the Plasma-devel mailing list