Review Request: Make the activities runner available for single runner use

Aaron J. Seigo aseigo at kde.org
Sun Apr 17 14:37:57 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101144/#review2701
-----------------------------------------------------------

Ship it!



plasma/generic/runners/activities/activityrunner.cpp
<http://git.reviewboard.kde.org/r/101144/#comment2384>

    can be combined into an "else if"; personally i find that easier to read than nested if's when there is no reason for it (usually a nested should implies that it is handling a unique sub-case)


- Aaron J.


On April 17, 2011, 12:37 a.m., Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101144/
> -----------------------------------------------------------
> 
> (Updated April 17, 2011, 12:37 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Summary
> -------
> 
> Enables the activities runner for single runner use; 
> allows for fast activity switching using an appropriate shortcut
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/activities/activityrunner.cpp 4df11268fc0f03abd79b972aaa90c40b6b27b9cf 
>   plasma/generic/runners/activities/plasma-runner-activityrunner.desktop 036b389bcfc5237bf74d6a3f11c0bab9e5979270 
> 
> Diff: http://git.reviewboard.kde.org/r/101144/diff
> 
> 
> Testing
> -------
> 
> Compiled and it works
> 
> 
> Thanks,
> 
> Jacopo De
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110417/1ea29830/attachment.htm 


More information about the Plasma-devel mailing list