Review Request: Plasmate:error while trying to open a project

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101141/#review2689
-----------------------------------------------------------


nice catch :)

there's a suggestion in my comments for a simpler and more future-proof solution. good job on tracking down the problem however.


mainwindow.cpp
<http://git.reviewboard.kde.org/r/101141/#comment2371>

    single quotes around the /, it's just one character :)



mainwindow.cpp
<http://git.reviewboard.kde.org/r/101141/#comment2372>

    what would make more sense to me is a simple check right here like:
    
    if (!packagePath.endsWith('/')) {
        packagePath.append('/');
    }
    
    and then all the code below can safely assume there is a trailing slash. a simpler and more consistent patch that way imho.


- Aaron J.


On April 16, 2011, 5:32 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101141/
> -----------------------------------------------------------
> 
> (Updated April 16, 2011, 5:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> hello,
> 
> while trying to open a project using a dir like this,
> "my_plasmoid/package" you will come across an error.With the patch plasmate is able to open correctly projects,which uses the previous directory.
> 
> Thank you for your time.:)
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp 17dcabd 
> 
> Diff: http://git.reviewboard.kde.org/r/101141/diff
> 
> 
> Testing
> -------
> 
> tested by me.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110416/235f3625/attachment.htm