Review Request: Fix plasma locale problems with multihead

Alberto Mattea alberto at mattea.info
Sat Apr 16 13:37:05 CEST 2011



> On April 16, 2011, 10:06 a.m., Christoph Feck wrote:
> > Compilation fails with this error:
> > 
> > kde-workspace/plasma/desktop/shell/plasmaapp.cpp:119:59: error: taking address of temporary

Weird, it works without problems here. I've seen aseigo has done further changes to this code. Maybe try again with latest git?


- Alberto


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101133/#review2676
-----------------------------------------------------------


On April 15, 2011, 2:09 p.m., Alberto Mattea wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101133/
> -----------------------------------------------------------
> 
> (Updated April 15, 2011, 2:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This small patch fixes locale problems with plasma multihead. Currently the shell on secondary screens is in English regardless of what is set in the preferences.
> 
> 
> This addresses bug 156475.
>     http://bugs.kde.org/show_bug.cgi?id=156475
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/main.cpp 0faf351 
>   plasma/desktop/shell/plasmaapp.cpp 86c6bfb 
> 
> Diff: http://git.reviewboard.kde.org/r/101133/diff
> 
> 
> Testing
> -------
> 
> It works here (for italian).
> 
> 
> Thanks,
> 
> Alberto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110416/f9b13f4b/attachment.htm 


More information about the Plasma-devel mailing list