Review Request: Make akonadi/kdepimlibs fully optional in kdeplasma-addons

Theo Chatzimichos tampakrap at gentoo.org
Tue Apr 12 03:27:57 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101095/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Added some code in #ifdef blocks to make akonadi/kdepimlibs depedencies fully optional. I am not sure of some parts, please check my inline comments


Diffs
-----

  libs/lancelot-datamodels/MessagesKmail.h 8db2a1c 
  libs/lancelot-datamodels/MessagesKmail.cpp 8fa89e0 
  runners/contacts/contactsrunner.cpp 2b5f3ec 
  runners/events/events_config.h f73b22b 

Diff: http://git.reviewboard.kde.org/r/101095/diff


Testing
-------

Seems to build and work fine, either with akonadi/kdepimlibs or without.


Thanks,

Theo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110412/c5a1cc8c/attachment.htm 


More information about the Plasma-devel mailing list