Review Request: DeclarativeImports-DataSource: Add the name of the changed source as parameter to the dataChanged() signal

[Marco Martin]

> On April 11, 2011, 11:33 a.m., Marco Martin wrote:
> > are you sure the property binding still works?
> > ime, even if the qt doc about it isn't clear at all, any signal set as NOTIFY of some qproperty does seem to work only if doesn't have any parameter
> 
> Anton Kreuzkamp wrote:
>     ah, not quite sure, I just know that onDataChanged gets invoked correctly and I can access the property.
>     What is the NOTIFY exactly needed for?

if for instance you have
Item {
  width: 200
  Item {
     width: parent.width
  }
}

the width of the child item will be correctly updated when the width of the parent item changes, that sync is done with the NOTIFY signal (see property bindings in the qml docs)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101081/#review2554
-----------------------------------------------------------


On April 11, 2011, 10:56 a.m., Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101081/
> -----------------------------------------------------------
> 
> (Updated April 11, 2011, 10:56 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Add the name of the changed source as parameter to the dataChanged() signal in the qml DataSource class.
> This eases up the qml-code massively and improves the performance, as I don't need to update all sources anymore, when just one source changes.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/datasource.cpp 0cd5a73 
>   plasma/declarativeimports/core/datasource_p.h 2d2cb13 
> 
> Diff: http://git.reviewboard.kde.org/r/101081/diff
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Anton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110411/06070c7b/attachment.htm