Review Request: Kinda fixes "memory leak" caused by comic plasmoid

[Matthias Fuchs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101046/
-----------------------------------------------------------

(Updated April 7, 2011, 3:46 p.m.)


Review request for Plasma and Aaron J. Seigo.


Changes
-------

Handles the prefetching soley in comic.cpp.
Further also adds a "Error automatically fixable" attribute to the dataengine. Make it possible to signal for the data engine if it will fix an error automatically as soon as that is possible.

PS.: Thanks for the reviewing, this really helps in creating better code! :)


Summary
-------

The comic plasmoid uses prefetching by calling Plasma::DataEngine::query(source).
Yet apparantly these created sources do not get removed automatically (?) causing an increase of memory usage the more comics are viewed.

E.g. looking at 15 strips of Lackadaisy that had not been cached before caused a memory usage of 114 MB for the plasmoidviewer. The patch reduces the usage in the same case to 52.9 MB. Each of these comics has a size between 1.2 MB and 2.6 MB.
So please comment on the patch! :)

I wonder why it is still that high with the patch after looking at some comics, so if you can help to reduce that further that would be great.
Further I wonder if some of the perceived "plasma mem leak" reports are caused by the way the comic plasmoid works.


Diffs (updated)
-----

  applets/comic/comic.cpp 3785f4f 
  dataengines/comic/comic.cpp 09bbafd 

Diff: http://git.reviewboard.kde.org/r/101046/diff


Testing
-------


Thanks,

Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110407/e1a6dcfb/attachment.htm