Review Request: allow SVGs to use systemcolors

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5495/#review7905
-----------------------------------------------------------


still not completely happy having to keep a separate xml dom, however, there are probably not going to be other ways for a while and the implementation seems pretty good, so modulo those little things it could go in


/trunk/KDE/kdelibs/plasma/svg.cpp
<http://svn.reviewboard.kde.org/r/5495/#comment8160>

    a check elements with the same id aren't existing should be done



/trunk/KDE/kdelibs/plasma/svg.cpp
<http://svn.reviewboard.kde.org/r/5495/#comment8159>

    so the coloring of the pixmap is still kept as retrocompatibility?



/trunk/KDE/kdelibs/plasma/theme.cpp
<http://svn.reviewboard.kde.org/r/5495/#comment8158>

    i wonder how much is the benefit vs cost of caching this?



/trunk/KDE/kdelibs/plasma/theme.cpp
<http://svn.reviewboard.kde.org/r/5495/#comment8157>

    the button widget should be modified if this will start to be used


- Marco


On 2010-09-30 11:41:09, Manuel Mommertz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5495/
> -----------------------------------------------------------
> 
> (Updated 2010-09-30 11:41:09)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> With this patch applied SVGs can put a style-element with id 'current-system-colors' in it, which gets replaced by a style with the current systemcolors. This allows SVGs to use colors like background color and text color from the system palette. Giving themes much more possibilitys then just coloring the resulting pixmap.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/theme.h 1180314 
>   /trunk/KDE/kdelibs/plasma/theme.cpp 1180314 
>   /trunk/KDE/kdelibs/plasma/svg.cpp 1180314 
> 
> Diff: http://svn.reviewboard.kde.org/r/5495/diff
> 
> 
> Testing
> -------
> 
> Changing theme, changing colorscheme
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100930/4ceff287/attachment-0001.htm