Review Request: don't do the animation when dropping extender items
Aaron Seigo
aseigo at kde.org
Thu Sep 30 13:21:09 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5494/#review7902
-----------------------------------------------------------
Ship it!
horribly ugly internals, but great results. which is, when one has to choose, the right arrangement.
- Aaron
On 2010-09-30 10:06:14, Giulio Camuffo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5494/
> -----------------------------------------------------------
>
> (Updated 2010-09-30 10:06:14)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This patch removes the appear animation when dropping an exteder item on a containment, instead it shows the applet already at full size, trying to resemble http://plasma.kde.org/dms/1/21_209_kicker4transparentfloatingexpa.gif
> This way it feels much more natural.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/plasma/containment.cpp 1181168
>
> Diff: http://svn.reviewboard.kde.org/r/5494/diff
>
>
> Testing
> -------
>
> It works, the only thing not optimal is that, at least on old pcs like mine, there is a slight delay between the disappear of the pixmap and the appear of the applet, causing a flicker.
>
>
> Thanks,
>
> Giulio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100930/1c09db9e/attachment.htm
More information about the Plasma-devel
mailing list