Review Request: Make kolourpicker color grab working from autohiding panels
Björn Ruberg
bjoern at ruberg-wegener.de
Tue Sep 28 12:01:19 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5465/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
Patch fixes the bug that the mouse grab of the color-picker goes away when the panel hides. The idea of initiating the grab not on the panel but on a self created widget is from ksnapshot.
I want someone to look at it because I want to commit it KDE 4.5 branch as a bugfix.
This addresses bug 252350.
https://bugs.kde.org/show_bug.cgi?id=252350
Diffs
-----
/trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.h 1180054
/trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp 1180054
Diff: http://svn.reviewboard.kde.org/r/5465/diff
Testing
-------
Had kolourpicker in an autohiding panel - and it suddenly works. Tested with an applet on the desktop too. Works.
Thanks,
Björn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100928/96bc1007/attachment.htm
More information about the Plasma-devel
mailing list