Review Request: Corona::exportLayout

[Chani Armitage]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5451/
-----------------------------------------------------------

(Updated 2010-09-27 14:38:42.056313)


Review request for Plasma.


Changes
-------

updated API and fixed the immutability thing


Summary
-------

this adds exportLayout to corona, which saves a group of containments to a config file and deletes them from the main config.

Activity::close() becomes a lot shorter by calling it, like this: m_corona->exportLayout(external, m_containments.values());

I feel a bit out of it today though, so tell me if I've missed anything obvious...


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/corona.h 1179499 
  trunk/KDE/kdelibs/plasma/corona.cpp 1179499 

Diff: http://svn.reviewboard.kde.org/r/5451/diff


Testing
-------

closing an activity while locked is perfectly safe now :)


Thanks,

Chani

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100927/661311b2/attachment.htm