Review Request: Do not use tree view for categories in the vertical widgets explorer
Anselmo Melo
anselmolsm at gmail.com
Mon Sep 27 12:57:34 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5446/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
The propose here is to remove the Tree View used in the widgets explorer in vertical orientation. In its place, use the same button of the horizontal orientation, what simplifies the code (removes a class and some checks) and improves the use of space as the widgets list can grow vertically.
Better if combined with http://reviewboard.kde.org/r/4676/ as we also gain the space currently occupied by the arrow buttons and the close button in the bottom left corner.
The screenshots attached show the current widget explorer with the categories tree view and the proposed one, using the categories button.
Diffs
-----
/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h 1179288
/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp 1179288
Diff: http://svn.reviewboard.kde.org/r/5446/diff
Testing
-------
Tested in both horizontal and vertical orientations.
Screenshots
-----------
current widgets explorer
http://svn.reviewboard.kde.org/r/5446/s/511/
proposed, not using the tree view
http://svn.reviewboard.kde.org/r/5446/s/512/
Thanks,
Anselmo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100927/f58d927d/attachment.htm
More information about the Plasma-devel
mailing list