Review Request: Use Plasma::ScrollWidget in the widget explorer
Anselmo Melo
anselmolsm at gmail.com
Mon Sep 27 12:44:41 CEST 2010
> On 2010-09-24 10:43:08, Beat Wolf wrote:
> > what is the status of this patch?
>
> Aurélien Gâteau wrote:
> I need to ping someone so that it gets reviewed.
I like this idea because it cleans the interface, specially in the vertical orientation.
The patch need to be updated due to recent changes in widgetexplorer.cpp, though.
- Anselmo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4676/#review7753
-----------------------------------------------------------
On 2010-08-04 21:02:11, Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4676/
> -----------------------------------------------------------
>
> (Updated 2010-08-04 21:02:11)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on plasma-devel.
>
> The horizontal orientation behaved a bit strangely: AbstractIconList was becoming much larger than the screen width. I had to change the layout code to include the "Close" button inside FilteringWidget layout instead of creating another layout.
>
> Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider sizes.
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h 1147944
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp 1147944
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h 1147944
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp 1147944
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h 1147944
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp 1147944
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 1147944
>
> Diff: http://svn.reviewboard.kde.org/r/4676/diff
>
>
> Testing
> -------
>
> Tested in both horizontal and vertical modes, with lists larger and smaller than the view.
>
>
> Thanks,
>
> Aurélien
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100927/7987c4eb/attachment.htm
More information about the Plasma-devel
mailing list