Review Request: Cleanups in pager

[Aaron Seigo]

> On 2010-09-17 16:18:36, Aaron Seigo wrote:
> > the patch doesn't apply to current trunk .. could you update the review board request? thanks :)
> 
> Anthony Bryant wrote:
>     I thought I did that yesterday (and there haven't been any commits to pager since then), does it still not apply?
> 
> Beat Wolf wrote:
>     does this patch solve https://bugs.kde.org/show_bug.cgi?id=250756 ?
> 
> Anthony Bryant wrote:
>     It does. It should make sure changes to the number of virtual desktops cause a resize of the widget every time, instead of having a 1/2 chance of ignoring them.

this patch still does not apply cleanly to trunk. did you edit or open the patch in a text editor, or some such, that messes with whitespace? if you are uploading your patch by hand, please try out the post-review tool: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5355/#review7667
-----------------------------------------------------------


On 2010-09-17 02:29:59, Anthony Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5355/
> -----------------------------------------------------------
> 
> (Updated 2010-09-17 02:29:59)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> * Make configAccepted() just write the new config, and make configChanged() conditionally update the plasmoid after reading the config back in.
> * Split the grid resizing logic into its own method: recalculateGridSizes(int rows), and make it detect more edge cases.
> * Rename the main size calculation method to updateSizes(bool allowResize), which will resize the applet to its preferred size if allowResize is true.
> * Fix a bug which caused applet resizes to be wrongly cancelled in some situations.
> * Code style cleanups, remove unused variables, etc.
> 
> (Sorry for putting so many changes into one patch)
> 
> 
> This addresses bug 250756.
>     https://bugs.kde.org/show_bug.cgi?id=250756
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.h 1176214 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp 1176214 
> 
> Diff: http://svn.reviewboard.kde.org/r/5355/diff
> 
> 
> Testing
> -------
> 
> Tested configuring the pager from the config interface and the desktop console, and that it responds correctly to changes in desktop count, and in FormFactor and size.
> 
> 
> Thanks,
> 
> Anthony
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100924/4a6a787b/attachment.html