Review Request: fewer pixmaps created in pixmap transitions

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5406/#review7724
-----------------------------------------------------------

Ship it!


modulo the usual little cleanings still needed the overall logic seems improved a lot


/trunk/KDE/kdelibs/plasma/animations/pixmaptransition_p.h
<http://svn.reviewboard.kde.org/r/5406/#comment7835>

    isCached() and setCached()?
    or usesCache() and setUsesCache()
    (with the property named usesCache)



/trunk/KDE/kdelibs/plasma/animations/pixmaptransition.cpp
<http://svn.reviewboard.kde.org/r/5406/#comment7836>

    how much is indented? ;)



/trunk/KDE/kdelibs/plasma/paintutils.cpp
<http://svn.reviewboard.kde.org/r/5406/#comment7837>

    this if shouldn't be needed anymore as well?


- Marco


On 2010-09-22 18:36:20, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5406/
> -----------------------------------------------------------
> 
> (Updated 2010-09-22 18:36:20)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This prevents the creation of new pixmaps as much as possible while doing transition effects at the cost of creating more pixmaps on the fly. It introduces a new property, cache, to PixmapTransition to restore the old behaviour. However, most of our widgets already do caching internally, so the added pixmap copy is just that: a copy. It sits around taking up pixmap memory for no particularly good reason. In the Javascript plasmoid I'm working on, it creates a table with buttons, some 146 buttons, in fact. This drops the Pixmap count from nearly 150 for the same (pixel-wise) button pixmap to 1.
> 
> Combined with my commits from last night and a new caching scheme for FrameSvg, creating these buttons has dropped from 6-9 seconds on my machine to 2-3 seconds.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/animations/pixmaptransition.cpp 1178174 
>   /trunk/KDE/kdelibs/plasma/animations/pixmaptransition_p.h 1178174 
>   /trunk/KDE/kdelibs/plasma/paintutils.cpp 1178174 
> 
> Diff: http://svn.reviewboard.kde.org/r/5406/diff
> 
> 
> Testing
> -------
> 
> git at coherenttheory.com:plasmoidprogress.git
> 
> 
> Thanks,
> 
> Aaron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100922/8ee140e1/attachment.htm