Review Request: new kwin effect: roundedcorners - make corners of the desktop rounded

[todd rme]

On Tue, Sep 21, 2010 at 6:05 PM, Nuno Pinheiro <nuno at oxygen-icons.org> wrote:
> A Terça, 21 de Setembro de 2010 21:41:33 Martin Gräßlin você escreveu:
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://svn.reviewboard.kde.org/r/5225/#review7713
>> -----------------------------------------------------------
>>
>>
>> I am still rather opposed to include this effect in a default workspace
>> setup. I really like the work you are putting into it, but I think that
>> this effect is hardly used by anyone and is not something that belongs
>> into a default setup. And we should not include everything and the
>> kitchensink because we can do it (therefore we have Compiz, see
>> http://smspillaz.wordpress.com/2010/09/15/philosophy/ ). I am also unhappy
>> with some of the effects we currently ship (including snow, which was
>> written by me), so this is more a general thing. I think such effects
>> should go to either kdeartwork, kdeplasma-addons or extragear. Till we
>> have found a nice solution I would recommend to publish on kde-look/apps
>> (although that is also not so nice as we tend to break the ABI).
>>
>>
>> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners
>> .cpp <http://svn.reviewboard.kde.org/r/5225/#comment7832>
>>
>>     This check looks superfluous. In line 35 you set glTexture to 0, so for
>> both xrender and opengl the pointer is at least 0. As deleting null
>> pointers is save you can get rid of the if statement and I think also of
>> the #ifdef.
>>
>>
>> - Martin
>>
>> On 2010-09-21 18:34:04, Christoph Fritz wrote:
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > http://svn.reviewboard.kde.org/r/5225/
>> > -----------------------------------------------------------
>> >
>> > (Updated 2010-09-21 18:34:04)
>> >
>> >
>> > Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
>> >
>> >
>> > Summary
>> > -------
>> >
>> > Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect
>> > makes corners of the desktop rounded. Older Macs and Monitors had this
>> > feature too.
>> >
>> >
>> > Diffs
>> > -----
>> >
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt 1170001
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp
>> >   1170001
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeList
>> >   s.txt PRE-CREATION
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedco
>> >   rners.desktop PRE-CREATION
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedco
>> >   rners.h PRE-CREATION
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedco
>> >   rners.cpp PRE-CREATION
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedco
>> >   rners_config.h PRE-CREATION
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedco
>> >   rners_config.cpp PRE-CREATION
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedco
>> >   rners_config.desktop PRE-CREATION
>> >   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedco
>> >   rners_config.ui PRE-CREATION
>> >
>> > Diff: http://svn.reviewboard.kde.org/r/5225/diff
>> >
>> >
>> > Testing
>> > -------
>> >
>> >
>> > Screenshots
>> > -----------
>> >
>> > roundedcorners_without_frame
>> >
>> >   http://svn.reviewboard.kde.org/r/5225/s/498/
>> >
>> > with_simulated_border
>> >
>> >   http://svn.reviewboard.kde.org/r/5225/s/499/
>> >
>> > Thanks,
>> >
>> > Christoph
> from a design prespective this efect is
> 1 noncence, removes the hit area on the edges of the scren.
> 2 not good enough, (if you would want to do it you should do it properlie via
> some shape distrotion mesh and some global lights and shadows)
>
> so IMO it should not be in defoult land
> oxygen guy, "I make the pretty pictures"

A bit off topic, but is this able to prevent the mouse from entering
certain portions of the screen?  If so, then could the technique be
used to prevent the mouse from entering invisible portions of the
screen when using two monitors with different resolutions?  Currently
it is easy for the mouse to get lost there, and it makes things more
difficult for unhiding panels.  Although there is a valid question
regarding whether rounded corners belongs in kwin, I think preventing
the mouse from going off-screen (from the user point of view) is
definitely worthwhile for inclusion in kwin.

-Todd