Review Request: new kwin effect: roundedcorners - make corners of the desktop rounded

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5225/#review7713
-----------------------------------------------------------


I am still rather opposed to include this effect in a default workspace setup. I really like the work you are putting into it, but I think that this effect is hardly used by anyone and is not something that belongs into a default setup. And we should not include everything and the kitchensink because we can do it (therefore we have Compiz, see http://smspillaz.wordpress.com/2010/09/15/philosophy/ ). I am also unhappy with some of the effects we currently ship (including snow, which was written by me), so this is more a general thing. I think such effects should go to either kdeartwork, kdeplasma-addons or extragear. Till we have found a nice solution I would recommend to publish on kde-look/apps (although that is also not so nice as we tend to break the ABI).


tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp
<http://svn.reviewboard.kde.org/r/5225/#comment7832>

    This check looks superfluous. In line 35 you set glTexture to 0, so for both xrender and opengl the pointer is at least 0. As deleting null pointers is save you can get rid of the if statement and I think also of the #ifdef.


- Martin


On 2010-09-21 18:34:04, Christoph Fritz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5225/
> -----------------------------------------------------------
> 
> (Updated 2010-09-21 18:34:04)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Summary
> -------
> 
> Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect makes corners of the desktop rounded.
> Older Macs and Monitors had this feature too.
> 
> 
> Diffs
> -----
> 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt 1170001 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp 1170001 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists.txt PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.desktop PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.h PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.cpp PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.desktop PRE-CREATION 
>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.ui PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5225/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> roundedcorners_without_frame
>   http://svn.reviewboard.kde.org/r/5225/s/498/
> with_simulated_border
>   http://svn.reviewboard.kde.org/r/5225/s/499/
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100921/0515e82d/attachment.htm