Review Request: Add an unit test for Plasma::ConfigLoader

Martin Blumenstingl darklight.xdarklight at googlemail.com
Sun Sep 12 23:45:49 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5329/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Currently I'm changing some of the code in Plasma::ConfigLoader.
I want to make sure that I don't break that much ;)

Thus I wrote a unit test for the config loader.
Currently all it does it testing if the config loader can parse the default-values correctly.
One test for each (data-)"type" which ConfigLoader can handle.

Unfortunately ConfigLoaderTest::intListDefaultValue does not work yet (everything else works)


Diffs
-----

  /trunk/KDE/kdelibs/plasma/tests/configloadertest.xml PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/tests/CMakeLists.txt 1174512 
  /trunk/KDE/kdelibs/plasma/tests/configloadertest.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/5329/diff


Testing
-------

I ran the tests on my box.
20/21 were successful.

The only one failing is: ConfigLoaderTest::intListDefaultValue
(and I need some help there)


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100912/17c7cac5/attachment.htm 


More information about the Plasma-devel mailing list