Review Request: configChanged() for the Tasks plasmoid

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5313/#review7545
-----------------------------------------------------------

Ship it!


looks good; another plasmoid down! :)


/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp
<http://svn.reviewboard.kde.org/r/5313/#comment7713>

    usually put the conditional on the end of the line above, e.g.:
    
    if (item->abstractItem() &&
        item->abstractItem()->..


- Aaron


On 2010-09-11 02:00:33, Anthony Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5313/
> -----------------------------------------------------------
> 
> (Updated 2010-09-11 02:00:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add configChanged() to the Tasks plasmoid, and fix a few warnings.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp 1173935 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 1173935 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 1173935 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.h 1173935 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1173935 
> 
> Diff: http://svn.reviewboard.kde.org/r/5313/diff
> 
> 
> Testing
> -------
> 
> Tested that tooltips can be toggled from both the UI and the desktop console, and that the other options still work from the UI.
> 
> 
> Thanks,
> 
> Anthony
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100911/55de9e4d/attachment.htm