Review Request: DataEngine: Add methods to allow disabling auto-deletion of data sources created on demand

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5312/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Allow DataEngine implementations to prevent DataEngine from automatically deleting sources create in sourceRequestEvent.

Rationale: engines that fetch a list of sources asynchronously at creation time (such as systemmonitor) may reasonably want to create dummy data sources when they are requested before the list has been fetched.  However, they probably don't want these to be removed again when disconnected from.


Diffs
-----

  /trunk/KDE/kdelibs/plasma/dataengine.cpp 1173953 
  /trunk/KDE/kdelibs/plasma/private/dataengine_p.h 1173953 
  /trunk/KDE/kdelibs/plasma/dataengine.h 1173953 

Diff: http://svn.reviewboard.kde.org/r/5312/diff


Testing
-------

It makes the systemmonitor engine work properly.  Specifically, it solves the bug in bubblemon where if you had the bubblemon displaying, say, CPU Total Load when plasma started and then changed it to, say, CPU Idle Load, the CPU Total Load source would be removed and there would be an empty place where it should be in the list in the config dialog.


Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100910/59f6e3d2/attachment.html