Review Request: wetter.com Ion: fix forecast retrieval for some geographic regions
Thilo-Alexander Ginkel
thilo at ginkel.com
Fri Sep 10 19:25:34 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5309/
-----------------------------------------------------------
Review request for Plasma and Shawn Starr.
Summary
-------
As it turned out, wetter.com seems to return temperatures as decimal fractions for some geographic regions (such as Turkey) whereas most other regions use integers. Retrieving weather data for these regions unfortunately failed as QString.toInt() does not work with decimal fractions.
Example XML data showcasing this is attached to the referenced bug report.
This fix corrects the issue by converting the data parsed from the XML to a double and then rounds it to an integer.
This addresses bug 236309.
https://bugs.kde.org/show_bug.cgi?id=236309
Diffs
-----
/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/weather/ions/wetter.com/ion_wettercom.cpp 1173706
Diff: http://svn.reviewboard.kde.org/r/5309/diff
Testing
-------
Thanks,
Thilo-Alexander
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100910/d117af22/attachment.htm
More information about the Plasma-devel
mailing list