Review Request: Added System Wallpaper and My Downloaded Wallpaper checkboxes to sildeshow config

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5705/#review8452
-----------------------------------------------------------

Ship it!


looks good, inc the tooltips, just fix up the braces situation before committing. thanks :)


/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://svn.reviewboard.kde.org/r/5705/#comment8808>

    braces



/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://svn.reviewboard.kde.org/r/5705/#comment8809>

    braces



/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://svn.reviewboard.kde.org/r/5705/#comment8810>

    braces


- Aaron


On 2010-10-30 22:50:25, Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5705/
> -----------------------------------------------------------
> 
> (Updated 2010-10-30 22:50:25)
> 
> 
> Review request for Plasma and Davide Bettio.
> 
> 
> Summary
> -------
> 
> Prompted by bug https://bugs.kde.org/show_bug.cgi?id=253360 and my own itch at not having the ability to easly add ~/.kde/share/wallpaper/ to the slideshow, I added these two checkboxes from this wishlist bug.  Let me know if you think the tooltips should be reworded I just took an initial stab at them.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1190748 
>   /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1190748 
>   /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui 1190748 
> 
> Diff: http://svn.reviewboard.kde.org/r/5705/diff
> 
> 
> Testing
> -------
> 
> I works quite well actually.  I still think we need to disable the apply and ok buttons when no checkbox is checked and no paths are in the listbox, but we work around that by putting the system folder in the list if there are no folders in the kconfig.
> 
> 
> Thanks,
> 
> Jeremy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101031/955c760a/attachment.htm